Repository navigation
fix(release): switch NuGet publishing to trusted publishing - #500
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest release failed on the first NuGet push because the stored NUGET_KEY had expired: https://github.com/finos/morphir-dotnet/actions/runs/42360680040. Deployment now exchanges a GitHub OIDC token through the pinned NuGet/login v1.2.0 action immediately before publishing, and passes only that temporary credential to PublishAll. The stored NuGet keys are no longer read.
The publishing job uses the production environment to match the newly created NuGet policy. Only that job receives id-token: write. A preflight check reports a missing NUGET_USER, and the deployment guide now documents the policy, scopes and recovery steps. Regression tests cover temporary credential use, OIDC permission scope and the required environment.
Repository setup completed: NUGET_USER=DamReev and the production Actions environment. The NuGet policy shown by the maintainer is active for package owner Morphir, glob Morphir*, finos/morphir-dotnet, deployment.yml, environment production, with permission to push new packages and versions. Live OIDC exchange remains to be verified by the next deployment.
Validation:
After merge, start a new deployment workflow_dispatch on main for 0.4.0-alpha.1. Re-running the old failed run would keep its stored-key workflow. This PR does not trigger publication or move the existing tag.